This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Fix range of single commit generation in init #8095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #8095 +/- ##
============================================
Coverage 82.64% 82.65%
============================================
Files 579 579
Lines 21011 21004 -7
Branches 3058 3058
============================================
- Hits 17364 17360 -4
+ Misses 3647 3644 -3
|
ishantiw
reviewed
Jan 30, 2023
ishantiw
approved these changes
Jan 31, 2023
janhack
suggested changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment for one issue.
Otherwise, the PR looks good and I just replied to the discussions.
janhack
approved these changes
Jan 31, 2023
This was referenced Feb 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8086
How was it solved?
Problem was
finalizedBlockHeader.aggregateCommit.height
can be removed from the BFT params, and it fails on the initialization. BecausemaxHeightCertified > finalizedBlockHeader.aggregateCommit.height
and up tomaxHeightCertified
there is no need of single commit. Therefore, we can usemaxHeightCertified
for the lower rangeHow was it tested?